linux-kernel - Re: [PATCH] cpufreq/intel_pstate: Set timer timeout correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.03.1304051943270.3817@gmail.com>
Date:	Fri, 5 Apr 2013 19:46:04 -0400 (EDT)
From:	Parag Warudkar <parag.lkml@...il.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
cc:	dirk.brandewie@...il.com, Adam Williamson <awilliam@...hat.com>,
	Parag Warudkar <parag.lkml@...il.com>, rjw@...k.pl,
	linux-kernel@...r.kernel.org, cpufreq@...r.kernel.org
Subject: Re: [PATCH] cpufreq/intel_pstate: Set timer timeout correctly



On Fri, 5 Apr 2013, Viresh Kumar wrote:

> On Thu, Apr 4, 2013 at 11:05 PM,  <dirk.brandewie@...il.com> wrote:
> > From: Dirk Brandewie <dirk.brandewie@...il.com>
> >
> > The current calculation of the delay time is wrong and a cut and paste
> > error from a previous experimental driver.  This can result in the
> > timeout being set to jiffies + 1 which setup the driver to race with
> > it's self if the apic timer interrupt happen at just the right time.
> >
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=920289
> >
> > Reported-by: Adam Williamson <awilliam@...hat.com>
> > Reported-by: Parag Warudkar <parag.lkml@...il.com>
> >
> > Signed-off-by: Dirk Brandewie <dirk.brandewie@...il.com>
> > ---
> >  drivers/cpufreq/intel_pstate.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> Looks fine, but I would like to see a Tested-by from Adam/Parag
> as they haven't said anything about this patch (even in bugzilla).
> 

I am running with the patch since yesterday - everything looks good.

The issue hasn't been reproducible on demand but some code reading and 
Dirk's explanation says the patch should fix the issue.

So - Tested-by: Parag Warudkar <parag.lkml@...il.com>

Parag
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/