linux-kernel - Re: [PATCH] cpufreq/intel_pstate: Set timer timeout correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <515E6461.3060800@redhat.com>
Date:	Thu, 04 Apr 2013 22:42:57 -0700
From:	Adam Williamson <awilliam@...hat.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
CC:	dirk.brandewie@...il.com, Parag Warudkar <parag.lkml@...il.com>,
	rjw@...k.pl, linux-kernel@...r.kernel.org, cpufreq@...r.kernel.org
Subject: Re: [PATCH] cpufreq/intel_pstate: Set timer timeout correctly

On 04/04/13 10:19 PM, Viresh Kumar wrote:
> On Thu, Apr 4, 2013 at 11:05 PM,  <dirk.brandewie@...il.com> wrote:
>> From: Dirk Brandewie <dirk.brandewie@...il.com>
>>
>> The current calculation of the delay time is wrong and a cut and paste
>> error from a previous experimental driver.  This can result in the
>> timeout being set to jiffies + 1 which setup the driver to race with
>> it's self if the apic timer interrupt happen at just the right time.
>>
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=920289
>>
>> Reported-by: Adam Williamson <awilliam@...hat.com>
>> Reported-by: Parag Warudkar <parag.lkml@...il.com>
>>
>> Signed-off-by: Dirk Brandewie <dirk.brandewie@...il.com>
>> ---
>>   drivers/cpufreq/intel_pstate.c |    1 -
>>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> Looks fine, but I would like to see a Tested-by from Adam/Parag
> as they haven't said anything about this patch (even in bugzilla).

I'll try. Note the bug is not reliably reproducible, all I can really do 
is run for a day or two and see if it crashes.
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | identi.ca: adamwfedora
http://www.happyassassin.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/