linux-kernel - Re: [PATCH] regulator: mc13783: Add device tree probe support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130407192157.GQ6597@opensource.wolfsonmicro.com>
Date:	Sun, 7 Apr 2013 20:21:58 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Alexander Shiyan <shc_work@...l.ru>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	Sascha Hauer <s.hauer@...gutronix.de>
Subject: Re: [PATCH] regulator: mc13783: Add device tree probe support

On Sun, Apr 07, 2013 at 09:02:11PM +0400, Alexander Shiyan wrote:
> Patch adds device tree probe support for mc13783-regulator driver.

I'd expect to see a document describing the binding for any new binding.

> +	if (num_parsed != num_regulators) {
> +		dev_warn(&pdev->dev,
> +		"parsed %d != regulators %d - check your device tree!\n",
> +			num_parsed, num_regulators);
>  
> -		init_data = &pdata->regulators[i];
> -		desc = &mc13783_regulators[init_data->id].desc;
> +		num_regulators = num_parsed;
> +		priv->num_regulators = num_regulators;

Why is this something we warn about?  Users should be able to omit
unused regulators, no point in adding nodes that don't have any real
information.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)