linux-kernel - Re: kernel BUG at kernel/smpboot.c:134!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1304071119100.21884@ionos>
Date:	Sun, 7 Apr 2013 11:20:10 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
cc:	Dave Hansen <dave@...1.net>, LKML <linux-kernel@...r.kernel.org>,
	Dave Jones <davej@...hat.com>, dhillf@...il.com,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: kernel BUG at kernel/smpboot.c:134!

On Sat, 6 Apr 2013, Thomas Gleixner wrote:
> This is Hillfs proposed patch:
> 
> > --- a/kernel/kthread.c	Sat Jan 19 13:03:52 2013
> > +++ b/kernel/kthread.c	Sat Jan 19 13:17:54 2013
> > @@ -306,6 +306,7 @@ struct task_struct *kthread_create_on_cp
> >   	  return p;
> > 	  set_bit(KTHREAD_IS_PER_CPU, &to_kthread(p)->flags);
> > 	  to_kthread(p)->cpu = cpu;
> > +	  __kthread_bind(p, cpu);
> > 	  /* Park the thread to get it out of TASK_UNINTERRUPTIBLE state */
> > 	  kthread_park(p);
> > 	  return p;
>  
> That's bogus. Simply because when we create the thread then the thread

And it's even more bogus because the cpu to which we would bind in
kthread_create_on_cpu() is not yet online.

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/