linux-kernel - Re: [PATCH 2/5] mmc: core: call pm_runtime_put_sync in pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK=Wgbb1_CgHpftEFmuqSKcCSjsjvyNCWEYNzQwC4vQKteaerQ@mail.gmail.com>
Date:	Sun, 7 Apr 2013 13:39:15 +0300
From:	Ohad Ben-Cohen <ohad@...ery.com>
To:	Li Fei <fei.li@...el.com>
Cc:	Chris Ball <cjb@...top.org>, ulf.hansson@...aro.org,
	johan.rudholm@...ricsson.com, subhashj@...eaurora.org,
	Philip Rakity <prakity@...vell.com>,
	rafael.j.wysocki@...el.com, thierry.reding@...onic-design.de,
	sachin.kamat@...aro.org,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chuansheng Liu <chuansheng.liu@...el.com>
Subject: Re: [PATCH 2/5] mmc: core: call pm_runtime_put_sync in
 pm_runtime_get_sync failed case

Hi Li,

On Thu, Feb 28, 2013 at 9:44 AM, Li Fei <fei.li@...el.com> wrote:
> Even in failed case of pm_runtime_get_sync, the usage_count
> is incremented. In order to keep the usage_count with correct
> value and runtime power management to behave correctly, call
> pm_runtime_put(_sync) in such case.

As with the remoteproc case, it is probably better to call the
put_noidle variant here. This way you are sure not to erroneously
invoke any underlying pm handler where your only intention is to fix
usage_count.

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/