linux-kernel - Re[2]: linux-next: build failure after merge of the mfd tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365438469.322553103@f51.mail.ru>
Date:	Mon, 08 Apr 2013 20:27:49 +0400
From:	Alexander Shiyan <shc_work@...l.ru>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re[2]: linux-next: build failure after merge of the mfd tree

> > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > > 
> > > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
> > > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]
> > > 
> > > Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support").
> > > 
> > > I have used the mfd tree from next-20130405 for today.
> > 
> > This means that we do not have empty declarations for the
> > of_xx functions in linux/of.h for !CONFIG_OF.
> > OK to declare these functions or any other opinions?
> Ok with me, but you'd need to get Grant and Rob's ACK.

I've revised my initial opinion and write a quick patch for fix this issue.

From a884d309d2978cbc44c52b650d669e56fef664e2 Mon Sep 17 00:00:00 2001
From: Alexander Shiyan <shc_work@...l.ru>
Date: Mon, 8 Apr 2013 19:13:10 +0400
Subject: [PATCH] regulator: anatop: Make select dependency from
 HAVE_IMX_ANATOP symbol

This patch make selection of anatop-regulator from HAVE_IMX_ANATOP
kernel symbol. This fixes build kernel with syscon driver but without
oftree support.

Signed-off-by: Alexander Shiyan <shc_work@...l.ru>
---
 drivers/regulator/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index a5d97ea..078932d 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -133,7 +133,7 @@ config REGULATOR_FAN53555
 
 config REGULATOR_ANATOP
 	tristate "Freescale i.MX on-chip ANATOP LDO regulators"
-	depends on MFD_SYSCON
+	depends on HAVE_IMX_ANATOP
 	help
 	  Say y here to support Freescale i.MX on-chip ANATOP LDOs
 	  regulators. It is recommended that this option be
-- 
1.8.1.5

---