linux-kernel - RE: [PATCH] staging/adt7316 Fix some 'interesting' string operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F1EA4089E@ORSMSX104.amr.corp.intel.com>
Date:	Mon, 8 Apr 2013 17:54:26 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Lars-Peter Clausen <lars@...afoo.de>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Bill Pemberton <wfp5p@...ginia.edu>,
	Joe Perches <joe@...ches.com>,
	Jonathan Cameron <jic23@....ac.uk>,
	Jonathan Cameron <jic23@...nel.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: RE: [PATCH] staging/adt7316 Fix some 'interesting' string operations

> I think it is a good idea to switch directly to strtobool. But anyway, if you
> don't want to respin the patch it is fine as it is.

I didn't know that strtobool() existed ... but now that I do I agree that it would
be better to use it here.  But ... I'm less comfortable updating the patch to use
it. User visible behavior would change (currently just "1" is considered "true",
but strtobool would also accept "y" and "Y").  I'd also have to think hard about
what to do if strtobool() said the input was not a valid boolean.

Thanks for the review.

-Tony