linux-kernel - Re: [PATCH] staging/adt7316 Fix some 'interesting' string operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51644BAF.7080202@kernel.org>
Date:	Tue, 09 Apr 2013 18:11:11 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	"Luck, Tony" <tony.luck@...el.com>
CC:	Lars-Peter Clausen <lars@...afoo.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Bill Pemberton <wfp5p@...ginia.edu>,
	Joe Perches <joe@...ches.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH] staging/adt7316 Fix some 'interesting' string operations

On 04/08/2013 06:54 PM, Luck, Tony wrote:
>> I think it is a good idea to switch directly to strtobool. But anyway, if you
>> don't want to respin the patch it is fine as it is.
> I didn't know that strtobool() existed ... but now that I do I agree that it would
> be better to use it here.  But ... I'm less comfortable updating the patch to use
> it. User visible behavior would change (currently just "1" is considered "true",
> but strtobool would also accept "y" and "Y").  I'd also have to think hard about
> what to do if strtobool() said the input was not a valid boolean.
>
> Thanks for the review.
>
> -Tony
I'll take the patch as is.  If anyone wants to do the strtobool conversion
as a follow up that would be great as well.  As a staging driver which doesn't
terribly closely correspond to any standard abi's I'd be inclined to not worry
to much about breaking userspace code that relies on the exact comparison
currently used as long as the obvious case still works.

Patch applied to togreg branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git

Thanks,

Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/