linux-kernel - Re: [PATCH] checkpatch: Check block comments outside of net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365507174.6865.31.camel@joe-AO722>
Date:	Tue, 09 Apr 2013 04:32:54 -0700
From:	Joe Perches <joe@...ches.com>
To:	Matthijs Kooijman <matthijs@...in.nl>
Cc:	Andy Whitcroft <apw@...onical.com>,
	Paul Zimmerman <Paul.Zimmerman@...opsys.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Check block comments outside of net

On Tue, 2013-04-09 at 13:19 +0200, Matthijs Kooijman wrote:
> There was some code checking block comments in net/ and drivers/net/,
> but nothing to check the regular block comment style.
[]
> Note that this patch rejects /** comments, since those are not mentioned
> in Codingstyle. They are used in practice though (around 1000 occurences
> in kernel/ alone), so perhaps they should be allowed and documented?

Those are kernel-doc comments and must be allowed.
see Documentation/kernel-doc-nano-HOWTO.txt

> Also, the new check only fires when the previous line is empty, just
> like the start of block comment check for net/. However, I couldn't find
> any documentation on why this restriction is needed?

I'm not that concerned about block comment style.
Maybe others are.

Please make it a --strict (CHK) only test for now.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/