linux-kernel - Re: [PATCH v3 0/7] f2fs: add tracepoints support in f2fs filesystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365467115.25498.35.camel@gandalf.local.home>
Date:	Mon, 08 Apr 2013 20:25:15 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	jaegeuk.kim@...sung.com, linux-f2fs-devel@...ts.sourceforge.net,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>
Subject: Re: [PATCH v3 0/7] f2fs: add tracepoints support in f2fs filesystem

On Sat, 2013-04-06 at 14:45 +0900, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@...sung.com>
> 
> Add tracepoints in f2fs filesystem for tracing the filesystem
> operations for information/debugging purpose if needed. All the
> tracepoints are clubbed with respect to functionalities.
> 
> Change Log:
> v3: Introduced TRACE_EVENT_CONDITION() macro for checking the
> condition page->mapping inside the trace point function call as
> per Steve's review comment for the patch
> 
> v2: Added DECLARE_EVENT_CLASS() macro for combining the similar
> type of trace function calls which has same type of arguments.
> 
> v1: Introduced the tracepoint functions in f2fs filesystem.
> 
> Namjae Jeon (7):
>   f2fs: add tracepoints for sync & Inode operations
>   f2fs: add tracepoints for truncate operation
>   f2fs: add tracepoint for tracing the page i/o operations
>   f2fs: add tracepoints for GC threads
>   f2fs: add tracepoints to debug the block allocation & fallocate
>   f2fs: add tracepoints for write page operations
>   f2fs: add tracepoints to debug checkpoint request
> 

I have nothing more to add about the tracepoint processing. Looks good.
Now if the tracepoints give you sufficient data? That's up to the
maintainers to decide.

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/