linux-kernel - Re: [PATCHv3] driver: serial: prevent UART console idle on suspend while using "no_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Apr 2013 10:57:09 +0530
From:	Sourav Poddar <sourav.poddar@...com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
CC:	<gregkh@...uxfoundation.org>, <tony@...mide.com>,
	<khilman@...aro.org>, <linux-omap@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	Felipe Balbi <balbi@...com>, Rajendra nayak <rnayak@...com>
Subject: Re: [PATCHv3] driver: serial: prevent UART console idle on suspend
 while using "no_console_suspend"

Hi Russell,
On Monday 08 April 2013 10:44 PM, Russell King - ARM Linux wrote:
> On Fri, Apr 05, 2013 at 06:45:33PM +0530, Sourav Poddar wrote:
>> With dt boot, uart wakeup after suspend is non functional while using
>> "no_console_suspend" in the bootargs. With "no_console_suspend" used, we
>> should prevent the runtime suspend of the uart port which is getting used
>> as an console.
>>
>> Cc: Santosh Shilimkar<santosh.shilimkar@...com>
>> Cc: Felipe Balbi<balbi@...com>
>> Cc: Rajendra nayak<rnayak@...com>
>> Tested on omap5430evm, omap4430sdp.
>>
>> Signed-off-by: Sourav Poddar<sourav.poddar@...com>
>> ---
>> v2->v3
>> Based on Kevin Hilman and Santosh Shilimkar comments, modified
>> serial core/driver layer to bypass runtime suspend
>> for console uart while using "no_console_suspend".
>>
>> This patch is based on Santosh Shilimkar serial patch[1]
> Rather than introducing this "port_is_console" thing, please move
> uart_console() into the serial_core.h header file, making it an inline
> function, and use that in omap-serial.c.
>
> Remember to fix drivers/tty/serial/mpc52xx_uart.c as well for that change.
Thanks for the pointer. Will take care of your suggestions
in the next version.

~Sourav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/