linux-kernel - Re: [PATCH] cciss: use lun reset not target reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <516567A9.7010606@redhat.com>
Date:	Wed, 10 Apr 2013 15:22:49 +0200
From:	Tomas Henzl <thenzl@...hat.com>
To:	"Stephen M. Cameron" <scameron@...rdog.cce.hp.com>
CC:	jens.axboe@...nel.dk, stephenmcameron@...il.com,
	akpm@...ux-foundation.org, mikem@...rdog.cce.hp.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cciss: use lun reset not target reset

almost the same patch has been accepted for hpsa so

Acked-by: Tomas Henzl <thenzl@...hat.com>

On 01/07/2013 05:30 PM, Stephen M. Cameron wrote:
> From: Stephen M. Cameron <scameron@...rdog.cce.hp.com>
>
> In the scsi part of the driver (for tape drives and medium changers)
> the device reset error handler attempts to use a target reset rather
> than a lun reset.  If there is some shared tape drive library, this
> could be potentially disruptive to other hosts trying to use the
> tape library.  Use lun reset instead to only reset the lun not the
> whole target.
>
> Signed-off-by: Stephen M. Cameron <scameron@...rdog.cce.hp.com>
> ---
>  drivers/block/cciss.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 6526157..64d1d82 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -2632,7 +2632,7 @@ static int fill_cmd(ctlr_info_t *h, CommandList_struct *c, __u8 cmd, void *buff,
>  			c->Request.Timeout = 0;
>  			memset(&c->Request.CDB[0], 0, sizeof(c->Request.CDB));
>  			c->Request.CDB[0] = cmd;	/* reset */
> -			c->Request.CDB[1] = CCISS_RESET_TYPE_TARGET;
> +			c->Request.CDB[1] = CCISS_RESET_TYPE_LUN;
>  			break;
>  		case CCISS_NOOP_MSG:
>  			c->Request.CDBLen = 1;
> @@ -2674,7 +2674,7 @@ static int __devinit cciss_send_reset(ctlr_info_t *h, unsigned char *scsi3addr,
>  		return -ENOMEM;
>  	return_status = fill_cmd(h, c, CCISS_RESET_MSG, NULL, 0, 0,
>  		CTLR_LUNID, TYPE_MSG);
> -	c->Request.CDB[1] = reset_type; /* fill_cmd defaults to target reset */
> +	c->Request.CDB[1] = reset_type; /* fill_cmd defaults to lun reset */
>  	if (return_status != IO_OK) {
>  		cmd_special_free(h, c);
>  		return return_status;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/