linux-kernel - Re: [PATCH] Input: synaptics - add retry mechanism for reconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <516567FF.7000802@canonical.com>
Date:	Wed, 10 Apr 2013 09:24:15 -0400
From:	James M Leddy <james.leddy@...onical.com>
To:	"Chung-Yih Wang (王崇懿)" 
	<cywang@...gle.com>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Daniel Kurtz <djkurtz@...omium.org>,
	Henrik Rydberg <rydberg@...omail.se>,
	Seth Forshee <seth.forshee@...onical.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	linux-kernel@...r.kernel.org, eric.miao@...onical.com,
	daniel.manrique@...onical.com, haitao.zhang@...onical.com
Subject: Re: [PATCH] Input: synaptics - add retry mechanism for reconnect

I'll have someone test it out. Thanks for the patch.

On 04/10/2013 01:40 AM, Chung-Yih Wang (王崇懿) wrote:
> Hi Eric Miao, James Leddy and Daniel Manrique,
> 
> If possible, could you give it a try for the patch I have on your device(s)?
> https://patchwork.kernel.org/patch/2156601/
> 
> I think we may address similar issue here. The synaptics device may not
> respond to the commands in synaptics_reconnect() for stress test of
> suspend/resume, so my patch is trying to do 
> the 'retry' for all requests in the reconnect path if one fails.
> 
> 
> 
> On Wed, Feb 20, 2013 at 2:50 AM, Dmitry Torokhov
> <dmitry.torokhov@...il.com <mailto:dmitry.torokhov@...il.com>> wrote:
> 
>     Hi Chung-yih,
> 
>     On Mon, Feb 18, 2013 at 04:40:21PM +0800, Chung-yih Wang wrote:
>     > On the Samsung Series 5 Chromebook, the Synaptics ClickPad will
>     sometimes not
>     > send an "0xFA" PS/2 ACK in response to a command byte during the
>     reconnect
>     > sequence following a resume from suspend. From our experiments,
>     the failure can
>     > happen during any byte of any of the commands in the reconnect batch.
>     >
>     > This failure results in a timeout in the psmouse driver. In
>     addition, the
>     > ClickPad will often also respond to the next PS/2 command byte
>     with an "0xFE"
>     > PS/2 RESEND response.
> 
>     Since you control the firmware of the device can you figure out under
>     what condition the touchpad does not acknowledge the commands sent to it
>     and fix it there?
> 
>     Thanks.
> 
>     --
>     Dmitry
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/