linux-kernel - Re: [char-misc-next 1/3] mei: nfc: Initial nfc implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130410172551.GA1881@kroah.com>
Date:	Wed, 10 Apr 2013 10:25:51 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	arnd@...db.de, linux-kernel@...r.kernel.org,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [char-misc-next 1/3] mei: nfc: Initial nfc implementation

On Tue, Apr 09, 2013 at 02:41:33AM +0300, Tomas Winkler wrote:
> From: Samuel Ortiz <sameo@...ux.intel.com>
> 
> NFC ME device is exported through the MEI bus to be consumed by the
> NFC subsystem.
> 
> NFC is represented by two mei clients: An info one and the actual
> NFC one. In order to properly build the ME id we first need to retrieve
> the firmware information from the info client and then disconnect from it.

I still don't understand why you aren't tieing this into the existing
nfc kernel api.  What am I missing?

> 
> Signed-off-by: Samuel Ortiz <sameo@...ux.intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> ---
>  drivers/misc/mei/Makefile     |   1 +
>  drivers/misc/mei/client.c     |   3 +
>  drivers/misc/mei/init.c       |   2 +
>  drivers/misc/mei/mei_dev.h    |  10 ++
>  drivers/misc/mei/nfc.c        | 250 ++++++++++++++++++++++++++++++++++++++++++
>  include/uapi/linux/Kbuild     |   1 +
>  include/uapi/linux/mei/Kbuild |   2 +
>  include/uapi/linux/mei/nfc.h  | 135 +++++++++++++++++++++++

Based on our previous off-list emails, you said that this .h file is
needed for the userspace api.  But the nfc userspace api is through the
nfc API, which doesn't use any of the structures defined here.  So who
exactly uses this file?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/