[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <170253117.11083340.1365614765343.JavaMail.root@redhat.com>
Date: Wed, 10 Apr 2013 13:26:05 -0400 (EDT)
From: Eric Paris <eparis@...hat.com>
To: Wei Yongjun <weiyj.lk@...il.com>
Cc: viro@...iv.linux.org.uk,
yongjun wei <yongjun_wei@...ndmicro.com.cn>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] audit: remove duplicated include from audit.c
net/netlink.h includes linux/netlink.h but linux/netlink.h does not include net/netlink.h
since the audit code uses the nlmsg_* functions provided in net/netlink.h it seems we need this include.
since the audit code uses netlink_unicast provided in linux/netlink.h it seems we need that include.
I don't see duplication even if by chance one of them would have included the other...
----- Original Message -----
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> Remove duplicated include.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
> kernel/audit.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 488f85f..9377913 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -58,7 +58,6 @@
> #ifdef CONFIG_SECURITY
> #include <linux/security.h>
> #endif
> -#include <net/netlink.h>
> #include <linux/freezer.h>
> #include <linux/tty.h>
> #include <linux/pid_namespace.h>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists