linux-kernel - Re: [PATCH UPDATED 1/7] x86: don't show trace into stacktrace machinery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130410202220.GB6854@pd.tnic>
Date:	Wed, 10 Apr 2013 22:22:20 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, mingo@...hat.com, x86@...nel.org,
	rth@...ddle.net, linux@....linux.org.uk, msalter@...hat.com,
	starvik@...s.com, dhowells@...hat.com, tony.luck@...el.com,
	benh@...nel.crashing.org, takata@...ux-m32r.org,
	geert@...ux-m68k.org, james.hogan@...tec.com, monstr@...str.eu,
	ralf@...ux-mips.org, jonas@...thpole.se, rkuo@...eaurora.org,
	schwidefsky@...ibm.com, liqin.chen@...plusct.com,
	davem@...emloft.net, lethal@...ux-sh.org, vgupta@...opsys.com,
	chris@...kel.net, cmetcalf@...era.com, ysato@...rs.sourceforge.jp,
	gxt@...c.pku.edu.cn, jdike@...toit.com
Subject: Re: [PATCH UPDATED 1/7] x86: don't show trace into stacktrace
 machinery

On Wed, Apr 10, 2013 at 01:10:20PM -0700, Tejun Heo wrote:
> +/* sanity check helper for dump_trace(), see dump_trace_current_frame() */
> +static inline void
> +dump_trace_warn_current_frame(struct task_struct *task, struct pt_regs *regs,
> +			      unsigned long bp)
> +{
> +	if ((!task || task == current) && !regs && !bp)
> +		printk(KERN_WARNING "dump_trace: %pf didn't specify neither frame nor regs for %%current\n",

This is double negation and is generally wrong in English. I think you
want to say:

"%pf specified neither frame nor regs for ..."

or

"%pf didn't specify either frame or regs for ..."

Or maybe even passive and shorter:

"%pf: No frame or regs specified for %%current."

and so on.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/