linux-kernel - Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365998409.1878.29.camel@joe-AO722>
Date:	Sun, 14 Apr 2013 21:00:09 -0700
From:	Joe Perches <joe@...ches.com>
To:	htl10@...rs.sourceforge.net
Cc:	Vyacheslav Dubeyko <slava@...eyko.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg

On Mon, 2013-04-15 at 04:46 +0100, Hin-Tak Leung wrote:
> > By converting this dprint() to pr_debug(), it would
> > print out on a multiple lines, one for each read.
> > 
> > That's why it should use a mechanism like dbg_cont.
> > 
> > btw: there is no current pr_debug_cont mechanism.
> 
> That's rubbish.

Don't be silly.

> dprint() are compiled in/out debug printing statements,
> and are entirely suppressed in unmodified kernel source

Of course.

> I am not saying what I have in private is correct

Then your original post wasn't useful either.

> What I am saying is that the code snipplet I posted is functional:

Lots of code is functional, I prefer functional
and correct though.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/