linux-kernel - Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365999738.30513.YahooMailClassic@web172302.mail.ir2.yahoo.com>
Date:	Mon, 15 Apr 2013 05:22:18 +0100 (BST)
From:	Hin-Tak Leung <htl10@...rs.sourceforge.net>
To:	Joe Perches <joe@...ches.com>
Cc:	Vyacheslav Dubeyko <slava@...eyko.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg

--- On Mon, 15/4/13, Joe Perches <joe@...ches.com> wrote:

> On Mon, 2013-04-15 at 04:46 +0100,
> Hin-Tak Leung wrote:
> > > By converting this dprint() to pr_debug(), it
> would
> > > print out on a multiple lines, one for each read.
> > > 
> > > That's why it should use a mechanism like
> dbg_cont.
> > > 
> > > btw: there is no current pr_debug_cont mechanism.
> > 
> > That's rubbish.
> 
> Don't be silly.
> 
> > dprint() are compiled in/out debug printing
> statements,
> > and are entirely suppressed in unmodified kernel
> source
> 
> Of course.
> 
> > I am not saying what I have in private is correct
> 
> Then your original post wasn't useful either.
> 
> > What I am saying is that the code snipplet I posted is
> functional:
> 
> Lots of code is functional, I prefer functional
> and correct though.
> 
> cheers, Joe

Hmm, you obvious has a different meaning of "functional" than I. How is converting a few hundred lines of "print nothing" to another few hundred lines of "print nothing" functional? What does it achieve?

I have already voiced my (admittedly selfish) concern: changing a few hundred lines of "print nothing" to another few hundred lines of "print nothing" means some of us who have substantial work-in-progress patches needs to spend a fair amount of time on rebase, and manually resolving conflicts from rebase.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/