linux-kernel - Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 14 Apr 2013 21:38:28 -0700
From:	Joe Perches <joe@...ches.com>
To:	htl10@...rs.sourceforge.net
Cc:	Vyacheslav Dubeyko <slava@...eyko.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg

On Mon, 2013-04-15 at 05:22 +0100, Hin-Tak Leung wrote:
> How is converting a few hundred lines of "print nothing" to
> another few hundred lines of "print nothing" functional?
> What does it achieve?

Standardization of output style when enabled.
Easier conversion to pr_debug/dynamic_debugging.
Emitting at KERN_DEBUG when enabled.

Besides, I was also doing the other logging
conversions at the same time to prefix hfs
differently than hfsplus.

I don't really care much when this stuff is
done, (it took about 10 minutes and it's about
all automatic and scripted) but I do think it
should be done.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/