| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1365990973.28177.YahooMailClassic@web172303.mail.ir2.yahoo.com> Date: Mon, 15 Apr 2013 02:56:13 +0100 (BST) From: Hin-Tak Leung <htl10@...rs.sourceforge.net> To: Joe Perches <joe@...ches.com> Cc: Vyacheslav Dubeyko <slava@...eyko.com>, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg --- On Mon, 15/4/13, Joe Perches <joe@...ches.com> wrote: > On Mon, 2013-04-15 at 01:53 +0100, > Hin-Tak Leung wrote: > > --- On Mon, 8/4/13, Joe Perches <joe@...ches.com> > wrote: > > > Use a more current logging style. > [] > > I have been sitting on a patch which changes this part > of the code to dynamic debugging, and it is much simplier. > Just: > > #define dprint(flg, fmt, args...) \ > > - if (flg & > DBG_MASK) \ > > - > printk(fmt , ## args) > > + > pr_debug(fmt , ## args) > > This change wouldn't work well as it would make a mess > of output that uses no prefix (ie: emits at KERN_DEFAULT) > with output that uses KERN_DEBUG > > That's the reason for _dbg and _dbg_cont. Hmm, I don't get it. Is there any *existing* use of dprint in the hfplus code which is affected by your comment? Or is this another general stylistic comment? i.e. "this does not work in general"? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists