linux-kernel - Re: [PATCH RFC 2/2] gpio: samsung: Remove OF support for Exynos4/5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZfZtfp5U4-Ab1ufbwBWVSvpDX_F=d-utokDXP7FbQmKw@mail.gmail.com>
Date:	Wed, 17 Apr 2013 18:35:34 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Sylwester Nawrocki <s.nawrocki@...sung.com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Kukjin Kim <kgene.kim@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	Thomas Abraham <thomas.abraham@...aro.org>,
	Olof Johansson <olof@...om.net>
Subject: Re: [PATCH RFC 2/2] gpio: samsung: Remove OF support for Exynos4/5

On Wed, Apr 17, 2013 at 1:06 PM, Sylwester Nawrocki
<s.nawrocki@...sung.com> wrote:

> -#endif
> +        * All Samsung platforms that support device tree will use the pinctrl
> +        * driver, hence we skip initialization of this driver if the OF tree
> +        * is available.
> +        */
> +       if (of_have_populated_dt())
> +               return -ENODEV;
>
>         samsung_gpiolib_set_cfg(samsung_gpio_cfgs, ARRAY_SIZE(samsung_gpio_cfgs));

Oh is that how you do it? It looks fragile.

Can't you check if you have the pinctrl node atleast?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/