linux-kernel - Re: [PATCH RFC 2/2] gpio: samsung: Remove OF support for Exynos4/5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51705025.4000107@gmail.com>
Date:	Thu, 18 Apr 2013 21:57:25 +0200
From:	Sylwester Nawrocki <sylvester.nawrocki@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Kukjin Kim <kgene.kim@...sung.com>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH RFC 2/2] gpio: samsung: Remove OF support for Exynos4/5

On 04/17/2013 06:35 PM, Linus Walleij wrote:
> On Wed, Apr 17, 2013 at 1:06 PM, Sylwester Nawrocki
> <s.nawrocki@...sung.com>  wrote:
>
>> -#endif
>> +        * All Samsung platforms that support device tree will use the pinctrl
>> +        * driver, hence we skip initialization of this driver if the OF tree
>> +        * is available.
>> +        */
>> +       if (of_have_populated_dt())
>> +               return -ENODEV;
>>
>>          samsung_gpiolib_set_cfg(samsung_gpio_cfgs, ARRAY_SIZE(samsung_gpio_cfgs));
>
> Oh is that how you do it? It looks fragile.
>
> Can't you check if you have the pinctrl node atleast?

But this driver won't help if there is no pinctrl node found anyway, since
any OF support is removed from it.

This way there is no need for any additional DT parsing, just to skip 
probing
of this legacy GPIO driver.

There might be something that could have gone wrong and I am missing though.

Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/