linux-kernel - Re: [PATCH 3/3] nohz: New option to default all CPUs in full dynticks range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130417200316.GH29861@linux.vnet.ibm.com>
Date:	Wed, 17 Apr 2013 13:03:16 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chris Metcalf <cmetcalf@...era.com>,
	Christoph Lameter <cl@...ux.com>,
	Geoff Levand <geoff@...radead.org>,
	Gilad Ben Yossef <gilad@...yossef.com>,
	Hakan Akkan <hakanakkan@...il.com>,
	Kevin Hilman <khilman@...aro.org>,
	Li Zhong <zhong@...ux.vnet.ibm.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 3/3] nohz: New option to default all CPUs in full
 dynticks range

On Wed, Apr 17, 2013 at 06:24:49PM +0200, Frederic Weisbecker wrote:
> Provide a new kernel config that defaults all CPUs to be part
> of the full dynticks range, except the boot one for timekeeping.
> 
> This default setting is overriden by the nohz_full= boot option
> if passed by the user.
> 
> This is helpful for those who don't need a finegrained range
> of full dynticks CPU and also for automated testing.
> 
> Suggested-by: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Chris Metcalf <cmetcalf@...era.com>
> Cc: Christoph Lameter <cl@...ux.com>
> Cc: Geoff Levand <geoff@...radead.org>
> Cc: Gilad Ben Yossef <gilad@...yossef.com>
> Cc: Hakan Akkan <hakanakkan@...il.com>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Kevin Hilman <khilman@...aro.org>
> Cc: Li Zhong <zhong@...ux.vnet.ibm.com>
> Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>

Reviewed-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

> ---
>  kernel/time/Kconfig      |   10 ++++++++++
>  kernel/time/tick-sched.c |   23 +++++++++++++++++++++--
>  2 files changed, 31 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
> index 358d601..99c3f13 100644
> --- a/kernel/time/Kconfig
> +++ b/kernel/time/Kconfig
> @@ -128,6 +128,16 @@ config NO_HZ_FULL
> 
>  endchoice
> 
> +config NO_HZ_FULL_ALL
> +       bool "Full dynticks system on all CPUs by default"
> +       depends on NO_HZ_FULL
> +       help
> +         If the user doesn't pass the nohz_full boot option to
> +	 define the range of full dynticks CPUs, consider that all
> +	 CPUs in the system are full dynticks by default.
> +	 Note the boot CPU will still be kept outside the range to
> +	 handle the timekeeping duty.
> +
>  config NO_HZ
>  	bool "Old Idle dynticks config"
>  	depends on !ARCH_USES_GETTIMEOFFSET && GENERIC_CLOCKEVENTS
> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> index d71a5f2..a76e090 100644
> --- a/kernel/time/tick-sched.c
> +++ b/kernel/time/tick-sched.c
> @@ -203,12 +203,31 @@ static int __cpuinit tick_nohz_cpu_down_callback(struct notifier_block *nfb,
>   */
>  static char __initdata nohz_full_buf[NR_CPUS + 1];
> 
> +static int tick_nohz_init_all(void)
> +{
> +	int err = -1;
> +
> +#ifdef CONFIG_NO_HZ_FULL_ALL
> +	if (!alloc_cpumask_var(&nohz_full_mask, GFP_KERNEL)) {
> +		pr_err("NO_HZ: Can't allocate full dynticks cpumask\n");
> +		return err;
> +	}
> +	err = 0;
> +	cpumask_setall(nohz_full_mask);
> +	cpumask_clear_cpu(smp_processor_id(), nohz_full_mask);
> +	have_nohz_full_mask = true;
> +#endif
> +	return err;
> +}
> +
>  void __init tick_nohz_init(void)
>  {
>  	int cpu;
> 
> -	if (!have_nohz_full_mask)
> -		return;
> +	if (!have_nohz_full_mask) {
> +		if (tick_nohz_init_all() < 0)
> +			return;
> +	}
> 
>  	cpu_notifier(tick_nohz_cpu_down_callback, 0);
> 
> -- 
> 1.7.5.4
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/