lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Apr 2013 10:30:12 +0100 From: Russell King - ARM Linux <linux@....linux.org.uk> To: Arnd Bergmann <arnd@...db.de> Cc: Lee Jones <lee.jones@...aro.org>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linus.walleij@...ricsson.com, Chris Ball <cjb@...top.org>, linux-mmc@...r.kernel.org Subject: Re: [PATCH] mmc: mmci: Allow MMCI to request channels with information acquired from DT On Thu, Apr 18, 2013 at 11:25:44AM +0200, Arnd Bergmann wrote: > +static void mmci_dma_setup(struct device *dev, struct mmci_host *host) > +{ > + const char *rxname, *txname; > + > + host->dma_rx_channel = dma_request_slave_channel(dev, "rx"); > + host->dma_tx_channel = dma_request_slave_channel(dev, "tx"); > + > + if (!host->dma_rx_channel && !host->dma_tx_channel) { > + if (host->plat && host->plat->dma_filter) > + mmci_dma_plat_setup(host); > + else > + dev_info(mmc_dev(host->mmc), "no DMA platform data\n"); > + return; You may like to fix the sillies in this patch... but yes, the above would be better. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists