linux-kernel - Re: [PATCH 12/12] radio-si476x: Fix incorrect pointer checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130418174815.GB26896@mwanda>
Date:	Thu, 18 Apr 2013 20:48:15 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Andrey Smirnov <andrew.smirnov@...il.com>
Cc:	sameo@...ux.intel.com, mchehab@...hat.com, hverkuil@...all.nl,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/12] radio-si476x: Fix incorrect pointer checking

On Thu, Apr 18, 2013 at 09:58:38AM -0700, Andrey Smirnov wrote:
> Fix incorrect pointer checking and make some minor code improvements:
> 
> * Remove unnecessary elements from function pointer table(vtable),
>   that includes all the elements that are FM-only, this allows for not
>   checking of the fucntion pointer and calling of the function
>   directly(THe check if the tuner is in FM mode has to be done anyway)
> 
> * Fix incorrect function pointer checking where the code would check one
>   pointer to be non-NULL, but would use other pointer, which would not
>   be checked.
> 
> * Remove code duplication in "si476x_radio_read_rsq_blob" and
>   "si476x_radio_read_rsq_primary_blob".
> 
> * Add some BUG_ON statements for function pointers that should never be NULL
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

This should be a Reported-by for me, probably.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/