| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Apr 2013 19:56:17 +0200 From: Samuel Ortiz <sameo@...ux.intel.com> To: Andrey Smirnov <andrew.smirnov@...il.com> Cc: mchehab@...hat.com, hverkuil@...all.nl, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, Hans Verkuil <hans.verkuil@...co.com> Subject: Re: [PATCH 11/12] si476x: Fix some config dependencies and a compile warnings On Thu, Apr 18, 2013 at 09:58:37AM -0700, Andrey Smirnov wrote: > From: Hans Verkuil <hverkuil@...all.nl> > > radio-si476x depends on SND and SND_SOC, the mfd driver should select > REGMAP_I2C. > > Also fix a small compile warning in a debug message: > > drivers/mfd/si476x-i2c.c: In function ‘si476x_core_drain_rds_fifo’: > drivers/mfd/si476x-i2c.c:391:4: warning: field width specifier ‘*’ expects argument of type ‘int’, but argument 4 has type ‘long unsigned int’ [-Wformat] > > Acked-by: Andrey Smirnov <andrew.smirnov@...il.com> > Signed-off-by: Hans Verkuil <hans.verkuil@...co.com> > --- > drivers/media/radio/Kconfig | 2 +- > drivers/mfd/Kconfig | 1 + > drivers/mfd/si476x-i2c.c | 2 +- You should have merged the MFD bits from this patch into one of the first 4 patches, that are MFD related. Or at least separated those 2 changes into 2 patches... Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists