[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20130420.154915.406609194782936166.davem@davemloft.net>
Date: Sat, 20 Apr 2013 15:49:15 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: jovi.zhangwei@...wei.com
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/8] spare/sysrq: fix inconstistent help message of
sysrq key
From: "zhangwei(Jovi)" <jovi.zhangwei@...wei.com>
Date: Sat, 20 Apr 2013 15:41:03 +0800
> On 2013/3/8 5:27, David Miller wrote:
>> From: "zhangwei(Jovi)" <jovi.zhangwei@...wei.com>
>> Date: Thu, 7 Mar 2013 17:00:32 +0800
>>
>>> Currently help message of /proc/sysrq-trigger highlight its
>>> upper-case characters, like below:
>>>
>>> SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E)
>>> memory-full-oom-kill(F) kill-all-tasks(I) ...
>>>
>>> this would confuse user trigger sysrq by upper-case character, which is
>>> inconsistent with the real lower-case character registed key.
>>>
>>> This inconsistent help message will also lead more confused when
>>> 26 upper-case letters put into use in future.
>>>
>>> This patch fix spare sysrq key: "global-regs(y)"
>>>
>>> Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@...wei.com>
>>
>> Acked-by: David S. Miller <davem@...emloft.net>
>>
> David, this patch is already got your ack,
> so would you please pick up this patch into your tree for next 3.10?
Sparc patches should be sent to sparclinux@...r.kernel.org so that they
are properly queued up and tracked in patchwork.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists