linux-kernel - Re: [PATCH 6/8] spare/sysrq: fix inconstistent help message of sysrq key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5172468F.7070909@huawei.com>
Date:	Sat, 20 Apr 2013 15:41:03 +0800
From:	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>
To:	David Miller <davem@...emloft.net>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/8] spare/sysrq: fix inconstistent help message of sysrq
 key

On 2013/3/8 5:27, David Miller wrote:
> From: "zhangwei(Jovi)" <jovi.zhangwei@...wei.com>
> Date: Thu, 7 Mar 2013 17:00:32 +0800
> 
>> Currently help message of /proc/sysrq-trigger highlight its
>> upper-case characters, like below:
>>
>>       SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E)
>>       memory-full-oom-kill(F) kill-all-tasks(I) ...
>>
>> this would confuse user trigger sysrq by upper-case character, which is
>> inconsistent with the real lower-case character registed key.
>>
>> This inconsistent help message will also lead more confused when
>> 26 upper-case letters put into use in future.
>>
>> This patch fix spare sysrq key: "global-regs(y)"
>>
>> Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@...wei.com>
> 
> Acked-by: David S. Miller <davem@...emloft.net>
> 
David, this patch is already got your ack,
so would you please pick up this patch into your tree for next 3.10?
Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/