linux-kernel - Re: [PATCH 2/2] dma: of: Remove check on always true condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201304221438.29857.arnd@arndb.de>
Date:	Mon, 22 Apr 2013 14:38:29 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	"Lars-Peter Clausen" <lars@...afoo.de>
Cc:	Vinod Koul <vinod.koul@...el.com>, Jon Hunter <jon-hunter@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dma: of: Remove check on always true condition

On Monday 22 April 2013, Lars-Peter Clausen wrote:
> Both of_dma_nbcells field of the of_dma_controller and the args_count field of
> the dma_spec are initialized by parsing the #dma-cells attribute of their device
> tree node. So if the device tree nodes of a DMA controller and the dma_spec
> match this means that of_dma_nbcells and args_count will also match. So the
> second test in the of_dma_find_controller loop is redundant because given the
> first test yields true the second test will also yield true. So we can safely
> remove the test whether of_dma_nbcells matches args_count. Since this was the
> last user of the of_dma_nbcells field we can remove it altogether.
> 
> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
> ---

Acked-by: Arnd Bergmann <arnd@...db.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/