linux-kernel - Re: [BUG] staging: android: ashmem: Deadlock during ashmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130422142218.GA26760@mwanda>
Date:	Mon, 22 Apr 2013 17:22:18 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Shankar Brahadeeswaran <shankoo77@...il.com>
Cc:	Robert Love <rlove@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Bjorn Bringert <bringert@...gle.com>,
	Al Viro <viro@...iv.linux.org.uk>, devel@...verdev.osuosl.org,
	Hugh Dickins <hughd@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	anjanavk12@...il.com
Subject: Re: [BUG] staging: android: ashmem: Deadlock during ashmem_shrink

Read Al's email again:  https://lkml.org/lkml/2013/3/20/458

I don't know much about VFS locking, but the ashmem locking seems
pretty bogus to me.  Why can't multiple threads read() at the same
time?

One thing is that it should probably be broken into different locks
instead of a mini-BKL.  Instead of taking a bad design and trying to
hack it until it doesn't crash I think it would be better to redo
the locking from scratch.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/