linux-kernel - Re: [PATCH] i2c-designware: fix RX FIFO overrun

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51465.163.33.213.85.1366739082.squirrel@linux.intel.com>
Date:	Tue, 23 Apr 2013 10:44:42 -0700 (PDT)
From:	"Josef Ahmad" <josef.ahmad@...ux.intel.com>
To:	"Wolfram Sang" <wsa@...-dreams.de>
Cc:	"Josef Ahmad" <josef.ahmad@...ux.intel.com>,
	"Mika Westerberg" <mika.westerberg@...ux.intel.com>,
	"Ben Dooks" <ben-linux@...ff.org>,
	"Jean Delvare" <khali@...ux-fr.org>, "Stefan Roese" <sr@...x.de>,
	"Axel Lin" <axel.lin@...il.com>, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Dirk Brandewie" <dirk.brandewie@...il.com>
Subject: Re: [PATCH] i2c-designware: fix RX FIFO overrun

> On Mon, Apr 22, 2013 at 03:08:59PM +0100, Josef Ahmad wrote:
>> From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001
>> From: Josef Ahmad <josef.ahmad@...ux.intel.com>
>> Date: Fri, 19 Apr 2013 17:28:10 +0100
>> Subject: [PATCH] i2c-designware: fix RX FIFO overrun
>>
>> i2c_dw_xfer_msg() pushes a number of bytes to transmit/receive
>> to/from the bus into the TX FIFO.
>> For master-rx transactions, the maximum amount of data that can be
>> received is calculated depending solely on TX and RX FIFO load.
>>
>> This is racy - TX FIFO may contain master-rx data yet to be
>> processed, which will eventually land into the RX FIFO. This
>> data is not taken into account and the function may request more
>> data than the controller is actually capable of storing.
>>
>> This patch ensures the driver takes into account the outstanding
>> master-rx data in TX FIFO to prevent RX FIFO overrun.
>>
>> Signed-off-by: Josef Ahmad <josef.ahmad@...ux.intel.com>
>> Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
>
> This driver had a major cleanup meanwhile. Could you rebase your patch
> on top of my for-next branch? I guess this version should make it into
> stable?
>

Hi Wolfram

This patch applies just fine on top of your i2c-embedded/for-next branch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/