lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 26 Apr 2013 10:19:15 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Li Fei <fei.li@...el.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, chuansheng.liu@...el.com,
	tomoki.sekiyama.qu@...achi.com, suresh.b.siddha@...el.com,
	joe@...ches.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: eliminate irq_mis_count counted in arch_irq_stat


* Li Fei <fei.li@...el.com> wrote:

> 
> With current implementation, kstat_cpu(cpu).irqs_sum is also
> increased in case of irq_mis_count increment.
> So there is no need to count irq_mis_count in arch_irq_stat,
> otherwise irq_mis_count will be counted twice in the sum of
> /proc/stat.
> 
> Signed-off-by: Liu Chuansheng <chuansheng.liu@...el.com>
> Signed-off-by: Li Fei <fei.li@...el.com>

The patch looks good, but this is not a valid signoff sequence. If Liu 
Chuansheng wrote this patch then his From: line should be included. If he 
acked it, then it should be added as Acked-by.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists