linux-kernel - Re: [PATCH 2/2] ipvs: Use cond_resched_rcu_lock() helper when dumping connections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1304300148260.1822@ja.ssi.bg>
Date:	Tue, 30 Apr 2013 02:12:10 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Simon Horman <horms@...ge.net.au>,
	Ingo Molnar <mingo@...hat.com>, lvs-devel@...r.kernel.org,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Dipankar Sarma <dipankar@...ibm.com>, dhaval.giani@...il.com
Subject: Re: [PATCH 2/2] ipvs: Use cond_resched_rcu_lock() helper when dumping
 connections


	Hello,

On Mon, 29 Apr 2013, Paul E. McKenney wrote:

> On Tue, Apr 30, 2013 at 12:08:18AM +0300, Julian Anastasov wrote:
> > 
> > 	Hello,
> > 
> > On Sat, 27 Apr 2013, Paul E. McKenney wrote:
> > 
> > > I would instead suggest something like:
> > > 
> > > #ifndef CONFIG_PREEMPT_RCU
> > > 
> > > But yes, in the CONFIG_PREEMPT_RCU case, the cond_resched() is not
> > > needed.
> > 
> > 	Hm, is this correct? If I follow the ifdefs
> > preempt_schedule is called when CONFIG_PREEMPT is
> > defined _and_ CONFIG_PREEMPT_RCU is not defined.
> > Your example for CONFIG_PREEMPT_RCU is the opposite to this?
> 
> Yep, I really did intend to say "#ifndef CONFIG_PREEMPT_RCU".
> 
> A couple of things to keep in mind:
> 
> 1.	Although rcu_read_unlock() does map to preempt_enable() for
> 	CONFIG_TINY_RCU and CONFIG_TREE_RCU, the current Kconfig refuses
> 	to allow either CONFIG_TINY_RCU or CONFIG_TREE_RCU to be selected
> 	if CONFIG_PREEMPT=y.

	I see, CONFIG_PREEMPT_RCU depends on CONFIG_PREEMPT

> 2.	In the CONFIG_PREEMPT_RCU case, __rcu_read_unlock() will check
> 	to see if the RCU core needs to be informed, so there is no
> 	need to invoke cond_resched() in that case.

	OK

> 3.	If we drop your "|| defined(CONFIG_PREEMPT_RCU)", we get an
> 	almost-synonym for my "#ifndef CONFIG_PREEMPT_RCU".  The "almost"
> 	applies to older kernels due to the possibility of having a
> 	CONFIG_TINY_PREEMPT_RCU kernel -- but this possibility is going
> 	away soon.
> 
> Make sense?

	Yes, thanks for the explanation!

	Simon, so lets do it as suggested by Eric and Paul:

	rcu_read_unlock();
#ifndef CONFIG_PREEMPT_RCU
	cond_resched();
#endif
	rcu_read_lock();

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/