linux-kernel - Re: clockevents_program_event WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1305022152280.2891@ionos>
Date:	Thu, 2 May 2013 21:58:03 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Dave Jones <davej@...hat.com>
cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Yinghai Lu <yhlu.kernel@...il.com>
Subject: Re: clockevents_program_event WARN_ON preventing boot.

On Thu, 2 May 2013, Dave Jones wrote:
> On Thu, May 02, 2013 at 12:37:26PM +0200, Thomas Gleixner wrote:
> 
>  > > On a second machine, I'm seeing an oops even earlier. As soon as I
>  > > exit grub, I get a blinking cursor.  If I boot with earlyprintk=vga
>  > > I can see..
>  > > 
>  > > Call Trace:
>  > >  <IRQ>
>  > >   tick_check_oneshot_broadcast
>  > >   tick_check_idle
>  > >   irq_enter
>  > >   do_IRQ
>  > >   common_interrupt
>  > >  <EOI>
>  > >   x86_64_start_reservations
>  > >   x86_64_start_kernel
>  > > RIP: clockevents_set_mode+0x18
>  > > 
>  > > Matching up the Code: line of the trace with the disassembly I see..
>  > > 
>  > >         if (dev->mode != mode) {
>  > >  4c8:   39 77 38                cmp    %esi,0x38(%rdi)
>  > > 
>  > > 
>  > 
>  > diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
>  > index 61d00a8..db9da73 100644
>  > --- a/kernel/time/tick-broadcast.c
>  > +++ b/kernel/time/tick-broadcast.c
>  > @@ -475,7 +475,8 @@ void tick_check_oneshot_broadcast(int cpu)
>  >  	if (cpumask_test_cpu(cpu, tick_broadcast_oneshot_mask)) {
>  >  		struct tick_device *td = &per_cpu(tick_cpu_device, cpu);
>  >  
>  > -		clockevents_set_mode(td->evtdev, CLOCK_EVT_MODE_ONESHOT);
>  > +		if (td)
>  > +			clockevents_set_mode(td->evtdev, CLOCK_EVT_MODE_ONESHOT);
>  >  	}
>  >  }
>  >  
> 
> td must be non-null, because this doesn't change anything.

Bah, I'm a moron. td is always non-null.

The check should be: 

    if (td->evtdev && tick_device_is_functional(td->evtdev))

> a clue: If I disable CONFIG_SLUB_DEBUG, or even boot with slub_debug=- then it boots fine.

Huch? That does not make any sense.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/