linux-kernel - Re: [RFC] regmap: debugfs: Fix start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130507142851.GU7478@sirena.org.uk>
Date:	Tue, 7 May 2013 15:28:51 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Srinivas KANDAGATLA <srinivas.kandagatla@...com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC] regmap: debugfs: Fix start_reg calculation

On Tue, May 07, 2013 at 02:11:37PM +0100, Srinivas KANDAGATLA wrote:

> regmap_debugfs_get_dump_start returns register number, not the actual
> offset into the map. So we use the return value as start to dump the 

No, it doesn't - it returns the register it should start reading from.
It's just that the code isn't paying attention to stride and should.
Fix the function, not the callers.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)