linux-kernel - Re: [PATCH] drm: refactor call to request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1367997761.10764.23.camel@mattotaupa>
Date:	Wed, 08 May 2013 09:22:41 +0200
From:	Paul Menzel <paulepanter@...rs.sourceforge.net>
To:	Kees Cook <keescook@...omium.org>
Cc:	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm: refactor call to request_module

Am Dienstag, den 07.05.2013, 12:32 -0700 schrieb Kees Cook:
> This reduces the size of the stack frame when calling request_module().
> Performing the sprintf before the call is not needed.

Good fine. Do you have any hard numbers for the record?

Did you find this just by reading the code or are there any problems
with stack sizes on some systems?

(This patch would be good alone for decreasing the number of code
lines. ;-))

> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  drivers/gpu/drm/drm_encoder_slave.c |    6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Acked-by: Paul Menzel <paulepanter@...rs.sourceforge.net>


Thanks,

Paul

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)