linux-kernel - Re: [PATCH] drm: refactor call to request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 8 May 2013 08:35:42 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Paul Menzel <paulepanter@...rs.sourceforge.net>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm: refactor call to request_module

On Wed, May 8, 2013 at 12:22 AM, Paul Menzel
<paulepanter@...rs.sourceforge.net> wrote:
> Am Dienstag, den 07.05.2013, 12:32 -0700 schrieb Kees Cook:
>> This reduces the size of the stack frame when calling request_module().
>> Performing the sprintf before the call is not needed.
>
> Good fine. Do you have any hard numbers for the record?
>
> Did you find this just by reading the code or are there any problems
> with stack sizes on some systems?
>
> (This patch would be good alone for decreasing the number of code
> lines. ;-))

No hard numbers; I just saw it while reviewing callers to request_module(). :)

>> Signed-off-by: Kees Cook <keescook@...omium.org>
>> ---
>>  drivers/gpu/drm/drm_encoder_slave.c |    6 +-----
>>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> Acked-by: Paul Menzel <paulepanter@...rs.sourceforge.net>

Thanks!

-Kees

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/