linux-kernel - Re: [PATCH 13/21] openrisc: delay: remove inline marking of EXPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 May 2013 11:45:44 +0100
From:	Will Deacon <will.deacon@....com>
To:	Denis Efremov <yefremov.denis@...il.com>
Cc:	Jonas Bonn <jonas@...thpole.se>,
	"linux@...nrisc.net" <linux@...nrisc.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"trivial@...nel.org" <trivial@...nel.org>,
	"ldv-project@...uxtesting.org" <ldv-project@...uxtesting.org>
Subject: Re: [PATCH 13/21] openrisc: delay: remove inline marking of
 EXPORT_SYMBOL functions

On Thu, May 09, 2013 at 11:36:51AM +0100, Denis Efremov wrote:
> EXPORT_SYMBOL and inline directives are contradictory to each other.
> The patch fixes this inconsistency.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Denis Efremov <yefremov.denis@...il.com>
> ---
>  arch/openrisc/lib/delay.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/openrisc/lib/delay.c b/arch/openrisc/lib/delay.c
> index c82b09f..808a55c 100644
> --- a/arch/openrisc/lib/delay.c
> +++ b/arch/openrisc/lib/delay.c
> @@ -37,7 +37,7 @@ void __delay(unsigned long cycles)
>  }
>  EXPORT_SYMBOL(__delay);
>  
> -inline void __const_udelay(unsigned long xloops)
> +void __const_udelay(unsigned long xloops)
>  {
>  	unsigned long long loops;

Acked-by: Will Deacon <will.deacon@....com>

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/