linux-kernel - Re: [PATCH 12/21] metag: delay: remove inline marking of EXPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <518B8292.3030700@imgtec.com>
Date:	Thu, 9 May 2013 12:03:46 +0100
From:	James Hogan <james.hogan@...tec.com>
To:	Denis Efremov <yefremov.denis@...il.com>
CC:	<linux-kernel@...r.kernel.org>, <trivial@...nel.org>,
	<ldv-project@...uxtesting.org>
Subject: Re: [PATCH 12/21] metag: delay: remove inline marking of EXPORT_SYMBOL
 functions

On 09/05/13 11:36, Denis Efremov wrote:
> EXPORT_SYMBOL and inline directives are contradictory to each other.
> The patch fixes this inconsistency.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Denis Efremov <yefremov.denis@...il.com>
> ---
>  arch/metag/lib/delay.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/metag/lib/delay.c b/arch/metag/lib/delay.c
> index 0b308f4..7ff0ca7 100644
> --- a/arch/metag/lib/delay.c
> +++ b/arch/metag/lib/delay.c
> @@ -36,7 +36,7 @@ void __delay(unsigned long loops)
>  }
>  EXPORT_SYMBOL(__delay);
>  
> -inline void __const_udelay(unsigned long xloops)
> +void __const_udelay(unsigned long xloops)
>  {
>  	u64 loops = (u64)xloops * (u64)loops_per_jiffy * HZ;
>  	__delay(loops >> 32);
> 

The inline still has an effect on code generation if other functions in
the same compilation unit use it, so this isn't really a trivial change.

I.e. before this patch __udelay and __ndelay inlined __const_udelay, but
after it they are changed to just multiply & branch.

Therefore I'd like to hear some more justification for these changes.

Cheers
James


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)