linux-kernel - Re: [PATCH 03/21] x86: remove inline marking of EXPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <518BA997.20401@zytor.com>
Date:	Thu, 09 May 2013 06:50:15 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Denis Efremov <yefremov.denis@...il.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org, trivial@...nel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH 03/21] x86: remove inline marking of EXPORT_SYMBOL functions

On 05/09/2013 12:58 AM, Denis Efremov wrote:
> EXPORT_SYMBOL and inline directives are contradictory to each other.
> The patch fixes this inconsistency.
> 
> Found by Linux Driver Verification project (linuxtesting.org).

Nice, but wrong.

They aren't contradictory; in gnu89 syntax this means "this can be
inline, but also create an out-of-line copy that others can call."

That being said, I haven't looked at the code to see if that makes
sense, but the statement isn't correct.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/