linux-kernel - Re: [PATCH RESEND 1/4] usb: ehci-s5p: fix memleak when devm_usb_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1305091529000.1796-100000@iolanthe.rowland.org>
Date:	Thu, 9 May 2013 15:29:13 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Libo Chen <libo.chen@...wei.com>
cc:	grant.likely@...aro.org, <rob.herring@...xeda.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<akpm@...ux-foundation.org>, <lizefan@...wei.com>
Subject: Re: [PATCH RESEND 1/4] usb: ehci-s5p: fix memleak when devm_usb_get_phy
 fail

On Thu, 9 May 2013, Libo Chen wrote:

> When devm_usb_get_phy fail, we should free hcd
> 
> Signed-off-by: Libo Chen <libo.chen@...wei.com>
> ---
>  drivers/usb/host/ehci-s5p.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
> index 6357752..3fbab58 100644
> --- a/drivers/usb/host/ehci-s5p.c
> +++ b/drivers/usb/host/ehci-s5p.c
> @@ -107,6 +107,7 @@ static int s5p_ehci_probe(struct platform_device *pdev)
>  	if (IS_ERR(phy)) {
>  		/* Fallback to pdata */
>  		if (!pdata) {
> +			usb_put_hcd(hcd);
>  			dev_warn(&pdev->dev, "no platform data or transceiver defined\n");
>  			return -EPROBE_DEFER;
>  		} else {

Acked-by: Alan Stern <stern@...land.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/