linux-kernel - Re: [PATCH RESEND 4/4] usb: tilegx: fix memleak when create hcd fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1305091529270.1796-100000@iolanthe.rowland.org>
Date:	Thu, 9 May 2013 15:29:38 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Libo Chen <libo.chen@...wei.com>
cc:	grant.likely@...aro.org, <rob.herring@...xeda.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<akpm@...ux-foundation.org>, <lizefan@...wei.com>
Subject: Re: [PATCH RESEND 4/4] usb: tilegx: fix memleak when create hcd fail

On Thu, 9 May 2013, Libo Chen wrote:

> When usb_create_hcd fail, we should call gxio_usb_host_destroy
> 
> Signed-off-by: Libo Chen <libo.chen@...wei.com>
> ---
>  drivers/usb/host/ohci-tilegx.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ohci-tilegx.c b/drivers/usb/host/ohci-tilegx.c
> index 1ae7b28..5888fc4 100644
> --- a/drivers/usb/host/ohci-tilegx.c
> +++ b/drivers/usb/host/ohci-tilegx.c
> @@ -112,8 +112,10 @@ static int ohci_hcd_tilegx_drv_probe(struct platform_device *pdev)
>  
>  	hcd = usb_create_hcd(&ohci_tilegx_hc_driver, &pdev->dev,
>  			     dev_name(&pdev->dev));
> -	if (!hcd)
> -		return -ENOMEM;
> +	if (!hcd){
> +		ret = -ENOMEM;
> +		goto err_hcd;
> +	}
>  
>  	/*
>  	 * We don't use rsrc_start to map in our registers, but seems like
> @@ -165,6 +167,7 @@ err_have_irq:
>  err_no_irq:
>  	tilegx_stop_ohc();
>  	usb_put_hcd(hcd);
> +err_hcd:
>  	gxio_usb_host_destroy(&pdata->usb_ctx);
>  	return ret;
>  }

Acked-by: Alan Stern <stern@...land.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/