linux-kernel - Re: [PATCH -v10 09/11] arm, prepare reboot_mode for moving to generic kernel code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130511191051.GE18614@n2100.arm.linux.org.uk>
Date:	Sat, 11 May 2013 20:10:52 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Robin Holt <holt@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Russ Anderson <rja@....com>,
	the arch/x86 maintainers <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Guan Xuetao <gxt@...c.pku.edu.cn>,
	Arm Mailing List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH -v10 09/11] arm, prepare reboot_mode for moving to
	generic kernel code.

Please, stop this idiotic incomprehensible jargon.

On Sat, May 11, 2013 at 08:47:28AM -0700, H. Peter Anvin wrote:
> By the way, do we really need Yoda programming here?
> 
> Russell King - ARM Linux <linux@....linux.org.uk> wrote:
> 
> >On Sat, May 11, 2013 at 06:57:25AM -0500, Robin Holt wrote:
> >> This patch prepares for the moving the parsing of reboot= to the
> >generic
> >> kernel code by making reboot_mode into a more generic form.
> >> 
> >> Signed-off-by: Robin Holt <holt@....com>
> >> To: Andrew Morton <akpm@...ux-foundation.org>
> >> To: Russell King <linux@....linux.org.uk>
> >> Cc: Russ Anderson <rja@....com>
> >> Cc: Robin Holt <holt@....com>
> >> Cc: H. Peter Anvin <hpa@...or.com>
> >> Cc: Guan Xuetao <gxt@...c.pku.edu.cn>
> >> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
> >> Cc: the arch/x86 maintainers <x86@...nel.org>
> >> Cc: Arm Mailing List <linux-arm-kernel@...ts.infradead.org>
> >
> >Almost-but-not-quite-Acked-by: Russell King
> ><rmk+kernel@....linux.org.uk> :)
> >
> >> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> >> index f219703..92b47df 100644
> >> --- a/arch/arm/kernel/process.c
> >> +++ b/arch/arm/kernel/process.c
> >> @@ -174,14 +174,14 @@ void arch_cpu_idle(void)
> >>  		default_idle();
> >>  }
> >>  
> >> -static char reboot_mode = 'h';
> >> +enum reboot_mode reboot_mode = REBOOT_HARD;
> >>  
> >> -int __init reboot_setup(char *str)
> >> +static int __init reboot_setup(char *str)
> >>  {
> >> -	reboot_mode = str[0];
> >> +	if ('s' == str[0])
> >> +		reboot_mode = REBOOT_SOFT;
> >
> >Remember we talked about the 'gpio' mode as well, so you also need here
> >+	if ('g' == str[0])
> >		reboot_mode = REBOOT_GPIO;
> 
> -- 
> Sent from my mobile phone. Please excuse brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/