linux-kernel - Re: [PATCH V1 resend] cpufreq: Raname index as data in cpufreq_frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohpo=hNaWF6kMLv5uQTM4sSHqozKySE31rDgQR+Dq6H6Mb9A@mail.gmail.com>
Date:	Mon, 13 May 2013 22:15:25 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	rjw@...k.pl, linaro-kernel@...ts.linaro.org, patches@...aro.org,
	cpufreq@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, robin.randhawa@....com,
	Steve.Bannister@....com, Liviu.Dudau@....com,
	charles.garcia-tobin@....com, arvind.chauhan@....com,
	Sekhar Nori <nsekhar@...com>, Ben Dooks <ben-linux@...ff.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Simon Horman <horms@...ge.net.au>,
	Magnus Damm <magnus.damm@...il.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Arnd Bergmann <arnd@...db.de>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Olof Johansson <olof@...om.net>,
	Srinidhi Kasagar <srinidhi.kasagar@...ricsson.com>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH V1 resend] cpufreq: Raname index as data in cpufreq_frequency_table

On 13 May 2013 21:57, Stephen Warren <swarren@...dotorg.org> wrote:
> On 05/13/2013 06:57 AM, Viresh Kumar wrote:
>> "Index" field of struct cpufreq_frequency_table was never index and isn't used
>> at all by cpufreq core. And is only useful for cpufreq drivers for their
>> personal use.
>>
>> Many people now a days blindly set it in ascending order with the assumption
>> that core is using it for some work.
>>
>> This patch renames it to "data" as that's what its purpose it. All users of the
>> same are fixed too.
>
>> diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c
>
>> -/* Frequency table index must be sequential starting at 0 */
>> +/* Frequency table data must be sequential starting at 0 */
>
> I assume that comment is due to the assumption you're trying to remove.
> Should the comment be removed/corrected now? Perhaps the .data field
> isn't even needed any more in this driver?

Probably removed and that too in a separate patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/