lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 May 2013 10:23:29 -0700 From: Yinghai Lu <yinghai@...nel.org> To: Jiang Liu <liuj97@...il.com> Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Gu Zheng <guz.fnst@...fujitsu.com>, "Rafael J . Wysocki" <rjw@...k.pl>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Toshi Kani <toshi.kani@...com>, Myron Stowe <myron.stowe@...hat.com>, Yijing Wang <wangyijing@...wei.com>, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, "David S. Miller" <davem@...emloft.net>, David Airlie <airlied@...ux.ie>, Neela Syam Kolli <megaraidlinux@....com>, "James E.J. Bottomley" <JBottomley@...allels.com>, Andrew Morton <akpm@...ux-foundation.org>, linuxppc-dev@...ts.ozlabs.org, "sparclinux@...r.kernel.org" <sparclinux@...r.kernel.org>, Linux-Scsi <linux-scsi@...r.kernel.org>, Jiang Liu <jiang.liu@...wei.com> Subject: Re: [PATCH v2, part 1 3/9] PCI: Convert alloc_pci_dev(void) to pci_alloc_dev(bus) instead On Mon, May 13, 2013 at 9:08 AM, Jiang Liu <liuj97@...il.com> wrote: > From: Gu Zheng <guz.fnst@...fujitsu.com> > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 4f0bc0a..bc075a3 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -1131,6 +1131,7 @@ static void pci_release_dev(struct device *dev) > struct pci_dev *pci_dev; > > pci_dev = to_pci_dev(dev); > + pci_bus_put(pci_dev->bus); > pci_release_capabilities(pci_dev); > pci_release_of_node(pci_dev); > kfree(pci_dev); > @@ -1269,11 +1270,10 @@ static struct pci_dev *pci_scan_device(struct pci_bus *bus, int devfn) > if (!pci_bus_read_dev_vendor_id(bus, devfn, &l, 60*1000)) > return NULL; > > - dev = alloc_pci_dev(); > + dev = pci_alloc_dev(bus); > if (!dev) > return NULL; > > - dev->bus = bus; > dev->devfn = devfn; > dev->vendor = l & 0xffff; > dev->device = (l >> 16) & 0xffff; in pci_setup_device() fail path, it release the ref to that bus. Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists