linux-kernel - Re: [PATCH] efivarfs: Never return ENOENT from firmware again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51913D4B.2000606@intel.com>
Date:	Mon, 13 May 2013 20:21:47 +0100
From:	Matt Fleming <matt.fleming@...el.com>
To:	Lingzhu Xiang <lxiang@...hat.com>
CC:	Jeremy Kerr <jk@...abs.org>,
	Matthew Garrett <matthew.garrett@...ula.com>,
	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Josh Boyer <jwboyer@...hat.com>,
	"Lee, Chun-Yi" <jlee@...e.com>, Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH] efivarfs: Never return ENOENT from firmware again

On 05/10/2013 11:29 AM, Lingzhu Xiang wrote:
> Previously in 1fa7e69 efi_status_to_err() translated firmware status
> EFI_NOT_FOUND to -EIO instead of -ENOENT for efivarfs operations to
> avoid confusion. After refactoring in e14ab23, it is also used in other
> places where the translation may be unnecessary.
> 
> So move the translation to efivarfs specific code. Also return EOF
> for reading zero-length files, which is what users would expect.
> 
> Cc: Josh Boyer <jwboyer@...hat.com>
> Cc: Jeremy Kerr <jk@...abs.org>
> Cc: Lee, Chun-Yi <jlee@...e.com>
> Cc: Andy Whitcroft <apw@...onical.com>
> Signed-off-by: Lingzhu Xiang <lxiang@...hat.com>
> ---
> This is to be applied against mainline or Matt Fleming's chainsaw branch.

Applied, thanks.

FYI, I rebased my 'urgent' branch on v3.10-rc1, so your patch now
applies there too.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/