linux-kernel - Re: [PATCHv2 net 2/2] sfc: Reduce RX scatter buffer size, and reduce alignment if appropriate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130514.113239.791038636818706716.davem@davemloft.net>
Date:	Tue, 14 May 2013 11:32:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	geert@...ux-m68k.org, heiko.carstens@...ibm.com,
	linux-net-drivers@...arflare.com, linux-kernel@...r.kernel.org,
	linux-s390@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCHv2 net 2/2] sfc: Reduce RX scatter buffer size, and
 reduce alignment if appropriate

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 13 May 2013 23:01:22 +0100

> efx_start_datapath() asserts that we can fit 2 RX scatter buffers plus
> a software structure, each appropriately aligned, into a single page.
> Where L1_CACHE_BYTES == 256 and PAGE_SIZE == 4096, which is the case
> on s390, this assertion fails.
> 
> The current scatter buffer size is also not a multiple of 64 or 128,
> which are more common cache line sizes.  If we can make both the start
> and end of a scatter buffer cache-aligned, this will reduce the need
> for read-modify-write operations on inter- processor links.
> 
> Fix the alignment by reducing EFX_RX_USR_BUF_SIZE to 2048 - 256 ==
> 1792.  (We could use 2048 - L1_CACHE_BYTES, but EFX_RX_USR_BUF_SIZE
> also affects user-level networking where a larger amount of
> housekeeping data may be needed.  Although this version of the driver
> does not support user-level networking, I prefer to keep scattering
> behaviour consistent with the out-of-tree version.)
> 
> This still doesn't fix the s390 build because like most architectures
> it has NET_IP_ALIGN == 2.  When NET_IP_ALIGN != 0 we cannot achieve
> cache line alignment at either the start or end of a scatter buffer,
> so there is actually no point in padding the buffers to a multiple of
> the cache line size.  All we need is 4-byte alignment of the network
> header, so do that.
> 
> Adjust the assertions accordingly.
> 
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Reported-by: Heiko Carstens <heiko.carstens@...ibm.com>
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/