linux-kernel - Re: [PATCHv2 net 2/2] sfc: Reduce RX scatter buffer size, and reduce alignment if appropriate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1374610772.2072.22.camel@bwh-desktop.uk.level5networks.com>
Date:	Tue, 23 Jul 2013 21:19:32 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
CC:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	<linux-net-drivers@...arflare.com>,
	"Linux Kernel Development" <linux-kernel@...r.kernel.org>,
	<linux-s390@...r.kernel.org>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCHv2 net 2/2] sfc: Reduce RX scatter buffer size, and
 reduce alignment if appropriate

On Mon, 2013-05-13 at 23:01 +0100, Ben Hutchings wrote:
[...]
> This still doesn't fix the s390 build because like most architectures
> it has NET_IP_ALIGN == 2.  When NET_IP_ALIGN != 0 we cannot achieve
> cache line alignment at either the start or end of a scatter buffer,
> so there is actually no point in padding the buffers to a multiple of
> the cache line size.  All we need is 4-byte alignment of the network
> header, so do that.
[...]

I was just thinking about this again.  Do we need to care about
alignment in a page fragment at all?  Won't all the headers be pulled
into the header area before being accessed with any instructions that
would require alignment?  (We aren't using build_skb().)

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/