linux-kernel - Re: [PATCH 02/15] perf util: Use evsel->name to get tracepoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87obcb4qou.fsf@sejong.aot.lge.com>
Date:	Thu, 16 May 2013 11:13:53 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	David Ahern <dsahern@...il.com>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 02/15] perf util: Use evsel->name to get tracepoint_paths

Hi Jiri,

On Wed, 15 May 2013 16:59:10 +0200, Jiri Olsa wrote:
> On Tue, May 14, 2013 at 07:13:46PM +0900, Namhyung Kim wrote:
>> diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
>> index ab18bf12d54a..bfcaeac7ef9d 100644
>> --- a/tools/perf/util/trace-event-info.c
>> +++ b/tools/perf/util/trace-event-info.c
>> @@ -414,12 +414,23 @@ get_tracepoints_path(struct list_head *pattrs)
>>  		if (pos->attr.type != PERF_TYPE_TRACEPOINT)
>>  			continue;
>>  		++nr_tracepoints;
>> +
>> +		if (pos->name) {
>> +			ppath->next = tracepoint_name_to_path(pos->name);
>
> yep, looks like big time saver ;)
>
>> +			if (!ppath->next)
>> +				goto error;
>
> hum, the tracepoint_name_to_path fails also because of the
> malformed tracepoint name.. then the error message is
> misleading.. but not quite sure this could happen

AFAIK it's called on the record path so every event is generated by
perf_evsel__newtp() and has a proper name.  But there's a way to specify
events using numeric form.. :(

So yes, I think it's better to consider such a exceptional case.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/