linux-kernel - Re: [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130520.021614.1748558994745374855.davem@davemloft.net>
Date:	Mon, 20 May 2013 02:16:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	eliezer.tamir@...ux.intel.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, jesse.brandeburg@...el.com,
	donanld.c.skidmore@...el.com, e1000-devel@...ts.sourceforge.net,
	willemb@...gle.com, andi@...stfloor.org, hpa@...or.com,
	eliezer@...ir.org.il
Subject: Re: [PATCH v2 net-next 1/4] net: implement support for low latency
 socket polling

From: Joe Perches <joe@...ches.com>
Date: Mon, 20 May 2013 01:29:47 -0700

> On Mon, 2013-05-20 at 00:54 -0700, David Miller wrote:
>> From: Eliezer Tamir <eliezer.tamir@...ux.intel.com>
> []
>> >  {
>> >       struct socket *sock;
>> > +     unsigned int poll_result;
>> 
>> Please order local variable declarations from longest line to
>> shortest line.
> 
> reverse christmas tree doesn't seem especially valuable or
> sensible for automatics.

It looks nicer to the eyes and provides a predictable pattern
to look at.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/